[ https://issues.apache.org/jira/browse/HIVE-27187?focusedWorklogId=854215&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-854215 ]
ASF GitHub Bot logged work on HIVE-27187: ----------------------------------------- Author: ASF GitHub Bot Created on: 31/Mar/23 15:39 Start Date: 31/Mar/23 15:39 Worklog Time Spent: 10m Work Description: deniskuzZ commented on code in PR #4166: URL: https://github.com/apache/hive/pull/4166#discussion_r1154628405 ########## ql/src/java/org/apache/hadoop/hive/ql/ddl/view/materialized/alter/rebuild/AlterMaterializedViewRebuildAnalyzer.java: ########## @@ -299,7 +300,8 @@ private RelNode applyRecordIncrementalRebuildPlan( // First we need to check if it is valid to convert to MERGE/INSERT INTO. // If we succeed, we modify the plan and afterwards the AST. // MV should be an acid table. - boolean fullAcidView = AcidUtils.isFullAcidTable(mvTable.getTTable()); + boolean fullAcidView = AcidUtils.isFullAcidTable(mvTable.getTTable()) Review Comment: var name is confusing, maybe acidView or txnView? Issue Time Tracking ------------------- Worklog Id: (was: 854215) Time Spent: 50m (was: 40m) > Incremental rebuild of materialized view having aggregate and stored by > iceberg > ------------------------------------------------------------------------------- > > Key: HIVE-27187 > URL: https://issues.apache.org/jira/browse/HIVE-27187 > Project: Hive > Issue Type: Improvement > Components: Iceberg integration, Materialized views > Reporter: Krisztian Kasa > Assignee: Krisztian Kasa > Priority: Major > Labels: pull-request-available > Time Spent: 50m > Remaining Estimate: 0h > > Currently incremental rebuild of materialized view stored by iceberg which > definition query contains aggregate operator is transformed to an insert > overwrite statement which contains a union operator if the source tables > contains insert operations only. One branch of the union scans the view the > other produces the delta. > This can be improved further: transform the statement to a multi insert > statement representing a merge statement to insert new aggregations and > update existing. -- This message was sent by Atlassian Jira (v8.20.10#820010)