[
https://issues.apache.org/jira/browse/HIVE-27295?focusedWorklogId=859119&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-859119
]
ASF GitHub Bot logged work on HIVE-27295:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Apr/23 09:22
Start Date: 26/Apr/23 09:22
Worklog Time Spent: 10m
Work Description: abstractdog commented on PR #4268:
URL: https://github.com/apache/hive/pull/4268#issuecomment-1523079640
> LGTM. Since `AbstractExternalDB` is more or less a copy (unfortunately :(
) of `DatabaseRule` we may want to apply the same improvements there; it can be
done as part of this PR or a separate one.
makes sense, I'm porting changes to DatabaseRule, otherwise I'll forget
forever
Issue Time Tracking
-------------------
Worklog Id: (was: 859119)
Time Spent: 1h 50m (was: 1h 40m)
> Improve docker logging in AbstractExternalDB
> --------------------------------------------
>
> Key: HIVE-27295
> URL: https://issues.apache.org/jira/browse/HIVE-27295
> Project: Hive
> Issue Type: Improvement
> Reporter: László Bodor
> Assignee: László Bodor
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> 1. While waiting for docker container to start properly, we should print the
> output of docker logs command in every loop, otherwise we can miss important
> information about the actual startup process if the docker container was oom
> killed in the meantime. Not to mention the fact that we're currently not
> logging the output at all in case of an error:
> https://github.com/apache/hive/blob/59058c65457fb7ab9d8575a555034e6633962661/itests/util/src/main/java/org/apache/hadoop/hive/ql/externalDB/AbstractExternalDB.java#L125-L127
> 2. We can include the output for docker events in the logs in case of an
> error (like: oom killed container), which might contain useful information.
> We can have info like this:
> {code}
> 2023-04-25T08:47:08.852515314-07:00 container oom
> 2ba12cd9cd844bb30b3158564bd68cd97f25e7a05172d111713ac9f7c1c0b1d4
> (image=harbor.rke-us-west-04.kc.cloudera.com/docker_private_cache/cloudera_thirdparty/postgres:9.3,
> name=qtestExternalDB-PostgresExternalDB)
> 2023-04-25T08:47:08.893742200-07:00 container die
> 2ba12cd9cd844bb30b3158564bd68cd97f25e7a05172d111713ac9f7c1c0b1d4 (exitCode=1,
> image=harbor.rke-us-west-04.kc.cloudera.com/docker_private_cache/cloudera_thirdparty/postgres:9.3,
> name=qtestExternalDB-PostgresExternalDB)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
