[ 
https://issues.apache.org/jira/browse/HIVE-23394?focusedWorklogId=860215&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-860215
 ]

ASF GitHub Bot logged work on HIVE-23394:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/May/23 06:57
            Start Date: 03/May/23 06:57
    Worklog Time Spent: 10m 
      Work Description: deniskuzZ commented on code in PR #4249:
URL: https://github.com/apache/hive/pull/4249#discussion_r1183302163


##########
itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcGenericUDTFGetSplits.java:
##########
@@ -38,14 +38,16 @@
 public class TestJdbcGenericUDTFGetSplits extends 
AbstractTestJdbcGenericUDTFGetSplits {
 
   @Test(timeout = 200000)
-  @Ignore("HIVE-23394")
   public void testGenericUDTFOrderBySplitCount1() throws Exception {
-    super.testGenericUDTFOrderBySplitCount1("get_splits", new int[]{10, 1, 0, 
2, 2, 2, 1, 10});
+    super.testGenericUDTFOrderBySplitCount1("get_splits", new int[] { 10, 5, 
0, 2, 2, 2, 5 });
+    super.testGenericUDTFOrderBySplitCount1("get_llap_splits", new int[] { 12, 
7, 1, 4, 4, 4, 7 });
   }
 
+
   @Test(timeout = 200000)
   public void testGenericUDTFOrderBySplitCount1OnPartitionedTable() throws 
Exception {
     super.testGenericUDTFOrderBySplitCount1OnPartitionedTable("get_splits", 
new int[]{5, 5, 1, 1, 1});
+    
super.testGenericUDTFOrderBySplitCount1OnPartitionedTable("get_llap_splits", 
new int[]{7, 7, 3, 3, 3});

Review Comment:
   why did we remove TestJdbcGenericUDTFGetSplits2 and merged both udfs under 
the same test?





Issue Time Tracking
-------------------

    Worklog Id:     (was: 860215)
    Time Spent: 1h 50m  (was: 1h 40m)

> TestJdbcGenericUDTFGetSplits2#testGenericUDTFOrderBySplitCount1 is flaky
> ------------------------------------------------------------------------
>
>                 Key: HIVE-23394
>                 URL: https://issues.apache.org/jira/browse/HIVE-23394
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Zoltan Haindrich
>            Assignee: Simhadri Govindappa
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> both 
> TestJdbcGenericUDTFGetSplits2.testGenericUDTFOrderBySplitCount1 and
> TestJdbcGenericUDTFGetSplits.testGenericUDTFOrderBySplitCount1        
> can fail with the exception below
> seems like the connection was lost
> {code}
> Error Message
> Failed to close statement
> Stacktrace
> java.sql.SQLException: Failed to close statement
>       at 
> org.apache.hive.jdbc.HiveStatement.closeStatementIfNeeded(HiveStatement.java:200)
>       at 
> org.apache.hive.jdbc.HiveStatement.closeClientOperation(HiveStatement.java:205)
>       at org.apache.hive.jdbc.HiveStatement.close(HiveStatement.java:222)
>       at 
> org.apache.hive.jdbc.AbstractTestJdbcGenericUDTFGetSplits.runQuery(AbstractTestJdbcGenericUDTFGetSplits.java:135)
>       at 
> org.apache.hive.jdbc.AbstractTestJdbcGenericUDTFGetSplits.testGenericUDTFOrderBySplitCount1(AbstractTestJdbcGenericUDTFGetSplits.java:164)
>       at 
> org.apache.hive.jdbc.TestJdbcGenericUDTFGetSplits2.testGenericUDTFOrderBySplitCount1(TestJdbcGenericUDTFGetSplits2.java:28)
>       at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>       at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>       at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>       at java.lang.reflect.Method.invoke(Method.java:498)
>       at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
>       at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>       at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
>       at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>       at 
> org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(FailOnTimeout.java:74)
> Caused by: org.apache.thrift.TApplicationException: CloseOperation failed: 
> out of sequence response
>       at org.apache.thrift.TServiceClient.receiveBase(TServiceClient.java:84)
>       at 
> org.apache.hive.service.rpc.thrift.TCLIService$Client.recv_CloseOperation(TCLIService.java:521)
>       at 
> org.apache.hive.service.rpc.thrift.TCLIService$Client.CloseOperation(TCLIService.java:508)
>       at sun.reflect.GeneratedMethodAccessor40.invoke(Unknown Source)
>       at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>       at java.lang.reflect.Method.invoke(Method.java:498)
>       at 
> org.apache.hive.jdbc.HiveConnection$SynchronizedHandler.invoke(HiveConnection.java:1732)
>       at com.sun.proxy.$Proxy146.CloseOperation(Unknown Source)
>       at 
> org.apache.hive.jdbc.HiveStatement.closeStatementIfNeeded(HiveStatement.java:193)
>       ... 14 more
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to