[ 
https://issues.apache.org/jira/browse/HIVE-27243?focusedWorklogId=861161&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-861161
 ]

ASF GitHub Bot logged work on HIVE-27243:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 09/May/23 09:33
            Start Date: 09/May/23 09:33
    Worklog Time Spent: 10m 
      Work Description: ayushtkn commented on code in PR #4289:
URL: https://github.com/apache/hive/pull/4289#discussion_r1188383476


##########
ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java:
##########
@@ -294,6 +295,14 @@ private void analyzeLoad(ASTNode ast) throws 
SemanticException {
       throw new SemanticException(ErrorMsg.DML_AGAINST_VIEW.getMsg());
     }
     if (ts.tableHandle.isNonNative()) {
+      // launch a tez job
+      StorageFormatDescriptor ss = 
ts.tableHandle.getStorageHandler().supportsLoadData(ts.tableHandle.getTTable());
+      if (ss != null) {

Review Comment:
   Could have done, but the inner logic is same, we have to check if native 
table is iceberg and then write.format and all constants aren't accessible from 
here, show some string hardcoding.
   
   For Append we have to any way go to StorageHandler to iceberg module to 
execute the append API's





Issue Time Tracking
-------------------

    Worklog Id:     (was: 861161)
    Time Spent: 3h  (was: 2h 50m)

> Iceberg: Implement Load data via temp table
> -------------------------------------------
>
>                 Key: HIVE-27243
>                 URL: https://issues.apache.org/jira/browse/HIVE-27243
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Ayush Saxena
>            Assignee: Ayush Saxena
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 3h
>  Remaining Estimate: 0h
>
> Do a load data for iceberg via ingesting it to a temp table and then Insert 
> into/overwrite. (Impala Approach)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to