[ https://issues.apache.org/jira/browse/HIVE-27406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770314#comment-17770314 ]
Stamatis Zampetakis commented on HIVE-27406: -------------------------------------------- The 4.0.0-beta-1 version is already out and this ticket is not part of it. I updated the Fix Version to indicate the next (possibly 4.0.0). > CompactionTxnHandler cleanup > ---------------------------- > > Key: HIVE-27406 > URL: https://issues.apache.org/jira/browse/HIVE-27406 > Project: Hive > Issue Type: Improvement > Components: Hive > Reporter: László Végh > Assignee: László Végh > Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > > Tech Debt elimination. Cleanup and standardize CompactionTxnHandler.java > considering the following items, but not limited to them: > * Check for proper javadoc > * Remove unnecessary logging, adjust log level properly > * Consistent transaction handling: > ** No rollback for selects > ** Exception in case of update count mismatch (single row update returns 0 > or >1 for updated rows) > ** Review proper usage of RetrySemantics.* annotations > * Common private template methods for 'infrastructure' code (same try-catch > logic, connection handling, etc: possibly with spring-jdbc > * Replace inline hardcoded and assembled SQL statements with parameterized > constants. -- This message was sent by Atlassian Jira (v8.20.10#820010)