[
https://issues.apache.org/jira/browse/HIVE-28153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837165#comment-17837165
]
Simhadri Govindappa commented on HIVE-28153:
--------------------------------------------
Change is merged to master.
Thanks, [~dkuzmenko] and [~zhangbutao] for the review!
Additionally, I have raised HIVE-28192 to investigate the bug mentioned above.
It seems like the IOContext is shared between threads in non-vectorized code
flow which is causing duplicate records.
> Flaky test TestConflictingDataFiles.testMultiFiltersUpdate
> ----------------------------------------------------------
>
> Key: HIVE-28153
> URL: https://issues.apache.org/jira/browse/HIVE-28153
> Project: Hive
> Issue Type: Test
> Components: Test
> Reporter: Butao Zhang
> Assignee: Simhadri Govindappa
> Priority: Major
> Labels: pull-request-available
>
> This test has been failing a lot lately, such as
> [http://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-5063/13/tests/]
>
> And the flaky test shows this test is unstable:
> [http://ci.hive.apache.org/job/hive-flaky-check/831/testReport/]
> {code:java}
> 10:29:21 [INFO] T E S T S
> 10:29:21 [INFO] -------------------------------------------------------
> 10:29:21 [INFO] Running org.apache.iceberg.mr.hive.TestConflictingDataFiles
> 10:36:13 [ERROR] Tests run: 60, Failures: 1, Errors: 0, Skipped: 24, Time
> elapsed: 399.12 s <<< FAILURE! - in
> org.apache.iceberg.mr.hive.TestConflictingDataFiles
> 10:36:13 [ERROR]
> org.apache.iceberg.mr.hive.TestConflictingDataFiles.testMultiFiltersUpdate[fileFormat=PARQUET,
> engine=tez, catalog=HIVE_CATALOG, isVectorized=false, formatVersion=1] Time
> elapsed: 11.781 s <<< FAILURE!
> 10:36:13 java.lang.AssertionError: expected:<12> but was:<13>
> 10:36:13 at org.junit.Assert.fail(Assert.java:89)
> 10:36:13 at org.junit.Assert.failNotEquals(Assert.java:835)
> 10:36:13 at org.junit.Assert.assertEquals(Assert.java:647)
> 10:36:13 at org.junit.Assert.assertEquals(Assert.java:633)
> 10:36:13 at
> org.apache.iceberg.mr.hive.TestConflictingDataFiles.testMultiFiltersUpdate(TestConflictingDataFiles.java:135)
> 10:36:13 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 10:36:13 at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 10:36:13 at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 10:36:13 at java.lang.reflect.Method.invoke(Method.java:498)
> 10:36:13 at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
> 10:36:13 at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> 10:36:13 at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
> 10:36:13 at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> 10:36:13 at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> 10:36:13 at
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> 10:36:13 at
> org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:54)
> 10:36:13 at
> org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299)
> 10:36:13 at
> org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293)
> 10:36:13 at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> 10:36:13 at java.lang.Thread.run(Thread.java:748) {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
