[
https://issues.apache.org/jira/browse/HIVE-28091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Butao Zhang resolved HIVE-28091.
--------------------------------
Fix Version/s: 4.1.0
Resolution: Fixed
Merged into master branch.
Thanks [~dkuzmenko] for the review!!!
> Remove invalid long datatype in ColumnStatsUpdateTask
> -----------------------------------------------------
>
> Key: HIVE-28091
> URL: https://issues.apache.org/jira/browse/HIVE-28091
> Project: Hive
> Issue Type: Improvement
> Reporter: Butao Zhang
> Assignee: Butao Zhang
> Priority: Trivial
> Labels: pull-request-available
> Fix For: 4.1.0
>
>
> [https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/exec/ColumnStatsUpdateTask.java#L104]
> {code:java}
> if (columnType.equalsIgnoreCase("long") ||
> columnType.equalsIgnoreCase("tinyint")
> || columnType.equalsIgnoreCase("smallint") ||
> columnType.equalsIgnoreCase("int")
> || columnType.equalsIgnoreCase("bigint")) {
> LongColumnStatsDataInspector longStats = new
> LongColumnStatsDataInspector(); {code}
> IMO, Hive column does not support long data type. We should remove the
> incorrect data type in ColumnStatsUpdateTask.
>
> In addition, the column stats related code blocks should be consistent with
> code in StatObjectConverter.java, which also does not have long type.
> [https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/StatObjectConverter.java#L378]
> {code:java}
> } else if (colType.equals("bigint") || colType.equals("int") ||
> colType.equals("smallint") || colType.equals("tinyint")) { {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
