[ 
https://issues.apache.org/jira/browse/HIVE-28345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stamatis Zampetakis resolved HIVE-28345.
----------------------------------------
    Fix Version/s: 4.1.0
       Resolution: Fixed

Fixed in 
https://github.com/apache/hive/commit/633af371edf0823967da2dca50c3893855dab626

Thanks for the reviews [~okumin] [~simhadri-g]!

> Avoid redundant HiveConf creation in MiniHS2.Builder
> ----------------------------------------------------
>
>                 Key: HIVE-28345
>                 URL: https://issues.apache.org/jira/browse/HIVE-28345
>             Project: Hive
>          Issue Type: Improvement
>          Components: Tests
>            Reporter: Stamatis Zampetakis
>            Assignee: Stamatis Zampetakis
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 4.1.0
>
>
> Every creation of a MiniHS2.Builder object triggers the creation  of a 
> [HiveConf 
> object|https://github.com/apache/hive/blob/1c9969a003b09abc851ae7e19631ad208d3b6066/itests/util/src/main/java/org/apache/hive/jdbc/miniHS2/MiniHS2.java#L100].
>  In many cases this new configuration object is thrown away and replaced by 
> another conf object via the [withConf 
> method|https://github.com/apache/hive/blob/1c9969a003b09abc851ae7e19631ad208d3b6066/itests/util/src/main/java/org/apache/hive/jdbc/miniHS2/MiniHS2.java#L159].
> Creating a HiveConf object is computationally heavy so for performance 
> reasons its best to avoid it if possible.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to