[ 
https://issues.apache.org/jira/browse/HIVE-28403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17868897#comment-17868897
 ] 

Stamatis Zampetakis commented on HIVE-28403:
--------------------------------------------

Hey [~caicancai], thanks for working on this. I really appreciate the time that 
you took in contributing this PR but I feel that these kind of changes have 
more negatives than positives for the project.

+Negatives:+
* Consume CI resources (runs are limited in Hive so this PR may block others 
from running)
* Increase likelihood of merge conflicts during backports
* Consume reviewers time (for checking and merging)
* Consume contributors time (they could spend their time on more impactful 
changes)
* Additional JIRA/git/mailing list traffic

+Positives:+
* Minor reduce in code size
* Other?

The above is my personal view point for such contributions and it does not mean 
that everyone in the Hive community agrees. I tend to avoid merging such 
contributions cause I have a limited amount of time and would like to focus on 
more impactful changes but other reviewers may be willing to get this in.

> Delete redundant Javadoc for Hive
> ---------------------------------
>
>                 Key: HIVE-28403
>                 URL: https://issues.apache.org/jira/browse/HIVE-28403
>             Project: Hive
>          Issue Type: Wish
>            Reporter: Caican Cai
>            Priority: Minor
>              Labels: pull-request-available
>
> Hive has some redundant Javadoc, but there are no comments in it. I think 
> some Javadoc can be deleted.
> {code:java}
> // Some comments here
>   /**
>    *
>    */
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to