[
https://issues.apache.org/jira/browse/HIVE-28401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17869887#comment-17869887
]
Alessandro Solimando commented on HIVE-28401:
---------------------------------------------
I am still OK with the changes as I agree that the tradeoff is reasonable.
The only suggestion I might have is to document the behaviour in the code and
cite SUREFIRE-2254.
> Drop redundant XML test report post-processing from CI pipeline
> ---------------------------------------------------------------
>
> Key: HIVE-28401
> URL: https://issues.apache.org/jira/browse/HIVE-28401
> Project: Hive
> Issue Type: Task
> Components: Testing Infrastructure
> Reporter: Stamatis Zampetakis
> Assignee: Stamatis Zampetakis
> Priority: Major
> Labels: pull-request-available
>
> The [Maven Surefire
> plugin|https://maven.apache.org/surefire/maven-surefire-plugin/#maven-surefire-plugin]
> generates an XML report containing various information regarding the
> execution of tests. In case of failures the system-out and system-err output
> from the test is saved in the XML file.
> The Jenkins pipeline has a post-processing
> [step|https://github.com/apache/hive/blob/78f577d73e5a49ca0f8f1dcae721f3980162872a/Jenkinsfile#L380]
> that attempts to remove the system-out and system-err entries from the XML
> files generated by Surefire for all tests that passed as an attempt to save
> disk space in the Jenkins node.
> {code:bash}
> # removes all stdout and err for passed tests
> xmlstarlet ed -L -d 'testsuite/testcase/system-out[count(../failure)=0]' -d
> 'testsuite/testcase/system-err[count(../failure)=0]'
> {code}
> This cleanup step is not necessary since Surefire (3.0.0-M4) is not storing
> system-out and system-err for tests that passed.
> Moreover, when the XML report file is large xmlstarlet chokes and throws a
> "Huge input lookup" error that skips the remaining post-processing steps and
> makes the build fail.
> {noformat}
> [2024-07-23T16:11:26.052Z]
> ./itests/qtest/target/surefire-reports/TEST-org.apache.hadoop.hive.cli.split31.TestMiniLlapLocalCliDriver.xml:53539.2:
> internal error: Huge input lookup
> [2024-07-23T16:11:26.053Z] 2024-07-23T09:02:51,799 INFO
> [734aa572-f1e1-4376-8c1c-9666c216e579 main] Sessio
> [2024-07-23T16:11:26.053Z] ^
> [2024-07-23T16:11:43.133Z] Recording test results
> [2024-07-23T16:11:50.785Z] [Checks API] No suitable checks publisher found.
> script returned exit code 3
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
