[ 
https://issues.apache.org/jira/browse/HIVE-12406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15018448#comment-15018448
 ] 

Szehon Ho commented on HIVE-12406:
----------------------------------

+1 lgtm.  Minor suggestion is to annotate the new class with public and 
stability interfaces to make it clear-er in future.

> HIVE-9500 introduced incompatible change to LazySimpleSerDe public interface
> ----------------------------------------------------------------------------
>
>                 Key: HIVE-12406
>                 URL: https://issues.apache.org/jira/browse/HIVE-12406
>             Project: Hive
>          Issue Type: Bug
>          Components: Serializers/Deserializers
>    Affects Versions: 1.2.0
>            Reporter: Lenni Kuff
>            Assignee: Aihua Xu
>            Priority: Blocker
>         Attachments: HIVE-12406.patch
>
>
> In the process of fixing HIVE-9500, an incompatibility was introduced that 
> will break 3rd party code that relies on LazySimpleSerde. In HIVE-9500, the 
> nested class SerDeParamaters was removed and the method 
> LazySimpleSerDe.initSerdeParms was also removed. They were replaced by a 
> standalone class LazySerDeParameters.
> Since this has already been released, I don't think we should revert the 
> change since that would mean breaking compatibility again. Instead, the best 
> approach would be to support both interfaces, if possible. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to