[ 
https://issues.apache.org/jira/browse/HIVE-28997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17956985#comment-17956985
 ] 

Shohei Okumiya commented on HIVE-28997:
---------------------------------------

Note: We may not need to work on this issue if we can fully replace Nashorn in 
HIVE-28984.

> Replace jdk.nashorn.internal.ir.debug.ObjectSizeCalculator
> ----------------------------------------------------------
>
>                 Key: HIVE-28997
>                 URL: https://issues.apache.org/jira/browse/HIVE-28997
>             Project: Hive
>          Issue Type: Improvement
>          Components: Test
>            Reporter: Shohei Okumiya
>            Assignee: Shohei Okumiya
>            Priority: Major
>              Labels: pull-request-available
>
> We are using nashorn-core to calculate an object size in 
> TestVectorMapJoinFastHashTable. JDK previously bundled Nashorn as of JDK 8, 
> and does not do so with JDK 17. So, we explicitly have a dependency on 
> Nashorn. The current setup has several drawbacks.
> - Although we use it in our test codes, it is a compile dependency of Hive
> - It is suspicious that we can redistribute it as a part of Hive, as the 
> license is GPL-like
> - The class, `jdk.nashorn.internal.ir.debug.ObjectSizeCalculator` which we 
> are using, belongs to an internal package and it'll be removed in the future
>  
> Therefore, we can explore a new option that replaces Nashorn. Fortunately, we 
> don't use it as a JavaScript engine.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to