[ 
https://issues.apache.org/jira/browse/HIVE-12490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15023245#comment-15023245
 ] 

Ashutosh Chauhan commented on HIVE-12490:
-----------------------------------------

+1 LGTM pending tests.
One optimization which I think is possible here is that this will currently 
send prepareTxn() and actual query separately. We could send them together in 
one call to RDBMS. How much gain (if any) we will get out of it though is I am 
not sure.
Anyway, we can do that later if we figure out there is substantial win to be 
had there. 

> Metastore: Mysql ANSI_QUOTES is not there for some cases
> --------------------------------------------------------
>
>                 Key: HIVE-12490
>                 URL: https://issues.apache.org/jira/browse/HIVE-12490
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 2.0.0
>            Reporter: Gopal V
>            Assignee: Sergey Shelukhin
>         Attachments: HIVE-12490.WIP.patch, HIVE-12490.patch
>
>
> {code}
> Caused by: com.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException: You 
> have an error in your SQL syntax; check the manual that corresponds to your 
> MySQL server version for the right syntax to use near '"PART_COL_STATS" where 
> "DB_NAME" = 'tpcds_100' and "TABLE_NAME" =
>  'store_sales' at line 1
> ...
>         at 
> org.datanucleus.api.jdo.NucleusJDOHelper.getJDOExceptionForNucleusException(NucleusJDOHelper.java:451)
>  ~[datanucleus-api-jdo-3.2.6.jar:?]
>         at 
> org.datanucleus.api.jdo.JDOQuery.executeWithArray(JDOQuery.java:321) 
> ~[datanucleus-api-jdo-3.2.6.jar:?]
>         at 
> org.apache.hadoop.hive.metastore.MetaStoreDirectSql.executeWithArray(MetaStoreDirectSql.java:1644)
>  [hive-exec-2.0.0-SNAPSHOT.jar:2.0.0-SNAPSHOT]
>         at 
> org.apache.hadoop.hive.metastore.MetaStoreDirectSql.partsFoundForPartitions(MetaStoreDirectSql.java:1227)
>  [hive-exec-2.0.0-SNAPSHOT.jar:2.0.0-SNAPSHOT]
>         at 
> org.apache.hadoop.hive.metastore.MetaStoreDirectSql.aggrColStatsForPartitions(MetaStoreDirectSql.java:1157)
>  [hive-exec-2.0.0-SNAPSHOT.jar:2.0.0-SNAPSHOT]
>         at 
> org.apache.hadoop.hive.metastore.ObjectStore$9.getSqlResult(ObjectStore.java:6659)
>  [hive-exec-2.0.0-SNAPSHOT.jar:2.0.0-SNAPSHOT]
>         at 
> org.apache.hadoop.hive.metastore.ObjectStore$9.getSqlResult(ObjectStore.java:6655)
>  [hive-exec-2.0.0-SNAPSHOT.jar:2.0.0-SNAPSHOT]
>         at 
> org.apache.hadoop.hive.metastore.ObjectStore$GetHelper.run(ObjectStore.java:2493)
>  [hive-exec-2.0.0-SNAPSHOT.jar:2.0.0-SNAPSHOT]
>         at 
> org.apache.hadoop.hive.metastore.ObjectStore.get_aggr_stats_for(ObjectStore.java:6655)
>  [hive-exec-2.0.0-SNAPSHOT.jar:2.0.0-SNAPSHOT]
>         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
> ~[?:1.8.0_40]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to