[ 
https://issues.apache.org/jira/browse/HIVE-29229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18024304#comment-18024304
 ] 

Butao Zhang commented on HIVE-29229:
------------------------------------

>> TestMiniLlapLocalCliDriver helps to debug code executed on llap daemons.
 
TestMiniLlapLocalCliDriver is beneficial for debugging code and is also the 
current default test class.

So, should we consider to remove TestMiniLlapCliDriver? I'm not sure what 
practical value TestMiniLlapCliDriver has.

> Consider deprecating and removing the TestMiniLlapCliDriver
> -----------------------------------------------------------
>
>                 Key: HIVE-29229
>                 URL: https://issues.apache.org/jira/browse/HIVE-29229
>             Project: Hive
>          Issue Type: Improvement
>          Components: Testing Infrastructure
>            Reporter: Butao Zhang
>            Priority: Major
>
> Tested against master branch, commit id: 
> https://github.com/apache/hive/commit/fda96f8a0db51207bc3ea8f95a9cd19bc5d94260
>  
> {code:java}
> mvn test -Dtest=TestMiniLlapLocalCliDriver -Dqfile=catalog.q 
> -Dtest.output.overwrite=true -pl itests/qtest -Pitests{code}
>  
> {code:java}
> mvn test -Dtest=TestMiniLlapCliDriver -Dqfile=catalog.q 
> -Dtest.output.overwrite=true -pl itests/qtest -Pitests{code}
>  
> I encountered a confusing discrepancy between the results of running 
> {{catalog.q}} with {{TestMiniLlapLocalCliDriver}} and 
> {{{}TestMiniLlapCliDriver{}}}. I haven't investigated the root cause yet.
> Since our CI has been defaulting to {{TestMiniLlapLocalCliDriver}} since 
> HIVE-23138, should we consider deprecating and removing 
> {{{}TestMiniLlapCliDriver{}}}? This would prevent confusion for Hive 
> developers and help streamline our test module code.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to