[ 
https://issues.apache.org/jira/browse/HIVE-29117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shohei Okumiya resolved HIVE-29117.
-----------------------------------
    Fix Version/s: 4.2.0
       Resolution: Fixed

Merged. [~wechar] Thank you!

https://github.com/apache/hive/pull/6006

> Refactor deleteDir and moveToTrash
> ----------------------------------
>
>                 Key: HIVE-29117
>                 URL: https://issues.apache.org/jira/browse/HIVE-29117
>             Project: Hive
>          Issue Type: Task
>          Components: Standalone Metastore
>            Reporter: Wechar
>            Assignee: Wechar
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 4.2.0
>
>
> We can refactor {{MetaStoreFS.deleteDir()}} and {{FileUtils.moveToTrash()}}  
> to get a cleaner code:
> 1. remove unused parameter {{recursive}}
> 2. remove {{purge}} parameter in moveToTrash because we should call 
> {{moveToTrash}} only when {{purge}} is false 
> 3. move {{fs.delete()}} calls from {{moveToTrash()}} to {{deleteDir()}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to