[
https://issues.apache.org/jira/browse/HIVE-22585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18022082#comment-18022082
]
Butao Zhang commented on HIVE-22585:
------------------------------------
Hi [~dlavati]
Great patch! I've been exploring the work related to HIVE-28879 recently, and I
noticed that the current code still has many places using the `db.tbl` string
format. I'm now considering adding the catalog to table name, which would
change it to a `cat.db.tbl` string. However, this approach makes the code
difficult to maintain and doesn't effectively pass catalog information. A more
elegant solution would be to replace all occurrences of table names with a
`TableName` object, making it easy to retrieve both the database and catalog
information of a table.
Are you planning to continue updating this PR?
Many thanks!
> Clean up catalog/db/table name usage
> ------------------------------------
>
> Key: HIVE-22585
> URL: https://issues.apache.org/jira/browse/HIVE-22585
> Project: Hive
> Issue Type: Sub-task
> Reporter: David Lavati
> Priority: Major
> Labels: pull-request-available, refactor
> Attachments: HIVE-22585.01.patch, HIVE-22585.02.patch,
> HIVE-22585.03.patch, HIVE-22585.04.patch, HIVE-22585.05.patch
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> This is a followup to HIVE-21198 to address some additional improvement ideas
> for the TableName object mentioned in
> [https://github.com/apache/hive/pull/550] and attempt to remove all the fishy
> usages of db/tablenames, as a number of places still rely on certain state
> changes/black magic.
> This change includes the following:
> * Remove reliance on Utilities.getDbTableName
> * Introduce a contract in TableName to always store catalog.dbname.tablename
> in lowercase
> * Make TableName a parsable type for ExplainTask
> * Additional refactors to leverage the TableName object
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
