[ 
https://issues.apache.org/jira/browse/HIVE-29554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18074104#comment-18074104
 ] 

Thomas Rebele commented on HIVE-29554:
--------------------------------------

Thank you for the review, [~dengzh]!

> Refactor MTableColumnStatistics and MPartitionColumnStatistics to avoid code 
> duplication
> ----------------------------------------------------------------------------------------
>
>                 Key: HIVE-29554
>                 URL: https://issues.apache.org/jira/browse/HIVE-29554
>             Project: Hive
>          Issue Type: Task
>            Reporter: Thomas Rebele
>            Assignee: Thomas Rebele
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 4.3.0
>
>
> Moving the common parts to a class/interface MColumnStatistics would reduce 
> code duplication. Some methods that use these two classes could be combined, 
> e.g.,
>  * StatObjectConverter#getTableColumnStatisticsObj
>  * StatObjectConverter#getPartitionColumnStatisticsObj
> and
>  * StatObjectConverter#convertToMTableColumnStatistics
>  * StatObjectConverter#convertToMPartitionColumnStatistics



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to