[
https://issues.apache.org/jira/browse/HIVE-29646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18089407#comment-18089407
]
Denys Kuzmenko edited comment on HIVE-29646 at 6/16/26 3:44 PM:
----------------------------------------------------------------
> I don't understand how the property can act as a guard with the way the code
> is right now. Are you proposing to re-purpose the property for other needs or
> are you referring to the actual state of the code in the repo/PR?
Yes, you are absolutely right. Given the current implementation, we could
simply drop the configuration entirely instead of patching
{{{}StatsUtils.checkCanProvideStats(){}}}.
If we agree that stat-based optimizations should also be allowed for external
tables, then the original rationale for the property becomes much weaker,
making its removal the cleanest option. A more conservative alternative would
be to keep the property but change its default value, preserving a way to
revert to the previous behavior if needed.
TPCDS 1TB
|{color:#000000}unsafe{color}|OFF|{color:#000000}ON{color}|
|{color:#000000}TOTAL
(sec){color}|{color:#000000}3256,4{color}|{color:#000000}3026,5{color}|
was (Author: dkuzmenko):
> I don't understand how the property can act as a guard with the way the code
> is right now. Are you proposing to re-purpose the property for other needs or
> are you referring to the actual state of the code in the repo/PR?
Yes, you are absolutely right. Given the current implementation, we could
simply drop the configuration entirely instead of patching
{{{}StatsUtils.checkCanProvideStats(){}}}.
If we agree that stat-based optimizations should also be allowed for external
tables, then the original rationale for the property becomes much weaker,
making its removal the cleanest option. A more conservative alternative would
be to keep the property but change its default value, preserving a way to
revert to the previous behavior if needed.
TPCDS 1TB
|{color:#000000}*unsafe*{color}|*OFF*|{color:#000000}*ON*{color}|
|{color:#000000}{*}TOTAL{*}{*}{*}{color}|{color:#000000}{*}3256,4{*}{*}{*}{color}|{color:#000000}{*}3026,5{*}{*}{*}{color}|
> Enable semijoin reduction and map-join conversion on external tables with
> accurate statistics
> ---------------------------------------------------------------------------------------------
>
> Key: HIVE-29646
> URL: https://issues.apache.org/jira/browse/HIVE-29646
> Project: Hive
> Issue Type: Improvement
> Reporter: Denys Kuzmenko
> Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
