[ 
https://issues.apache.org/jira/browse/HIVE-29765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18101371#comment-18101371
 ] 

Ruben Q L commented on HIVE-29765:
----------------------------------

bq. if we really need an unparse method if we drop the OPTIMIZED SQL entry.

In practice, maybe not. But since this method comes from Calcite's SqlOperator, 
if we override it IMO we should make it correct. Perhaps it's not used now, but 
might be useful in the future for whatever purpose.

> HiveBetween#unparse ignores negated flag
> ----------------------------------------
>
>                 Key: HIVE-29765
>                 URL: https://issues.apache.org/jira/browse/HIVE-29765
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Ruben Q L
>            Assignee: Ruben Q L
>            Priority: Major
>              Labels: pull-request-available
>
> HiveBetween first operand is a boolean "negated" flag. When it is disabled 
> (default) the operator represents a standard BETWEEN. When it is enabled, the 
> operator represents a NOT BETWEEN. However, in the HiveBetween#unparse method 
> the flag is not considered, so in all cases it is unparsed as a "BETWEEN" 
> (even when the flag is activated).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to