[
https://issues.apache.org/jira/browse/HIVE-30181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Raghav Aggarwal updated HIVE-30181:
-----------------------------------
Description:
*Problem Statement*
Hive maintains several internal test helper classes, data generators, and unit
tests under {{iceberg/}} that duplicate classes already maintained and
published in upstream Apache Iceberg test jars (e.g., {{{}iceberg-data{}}},
{{{}iceberg-api{}}}, and {{{}iceberg-core{}}}). Additionally, several retained
MR tests were still using JUnit 4 conventions diverging from upstream Iceberg's
modernized JUnit 5 test suite.
*Proposed Changes*
1. Reuse Upstream Iceberg Test Jars & Remove Redundancies
* Added {{test-jar}} dependencies for {{{}iceberg-data{}}},
{{{}iceberg-api{}}}, and {{iceberg-core}} in {{iceberg/pom.xml}} and
{{{}iceberg/iceberg-handler/pom.xml{}}}.
* Removed 9 redundant test helper / utility files (~2,000 LOC eliminated):
** {{iceberg-catalog/.../TestHelpers.java}}
** {{iceberg-handler/.../data/DeleteReadTests.java}}
** {{iceberg-handler/.../data/FileHelpers.java}}
** {{iceberg-handler/.../data/GenericAppenderHelper.java}}
** {{iceberg-handler/.../data/IcebergGenerics2.java}} (replaced with upstream
{{{}IcebergGenerics{}}})
** {{iceberg-handler/.../data/RandomGenericData.java}}
** {{iceberg-handler/.../util/RandomUtil.java}}
** {{iceberg-handler/.../util/TestCharSequenceSet.java}}
** {{iceberg-handler/.../util/TestLocationUtil.java}}
2. Modernize Retained MR Tests to JUnit 5 & Sync with Upstream
> Reuse upstream Iceberg test jars and migrate MR unit tests to JUnit 5
> ---------------------------------------------------------------------
>
> Key: HIVE-30181
> URL: https://issues.apache.org/jira/browse/HIVE-30181
> Project: Hive
> Issue Type: Sub-task
> Reporter: Raghav Aggarwal
> Assignee: Raghav Aggarwal
> Priority: Major
>
> *Problem Statement*
> Hive maintains several internal test helper classes, data generators, and
> unit tests under {{iceberg/}} that duplicate classes already maintained and
> published in upstream Apache Iceberg test jars (e.g., {{{}iceberg-data{}}},
> {{{}iceberg-api{}}}, and {{{}iceberg-core{}}}). Additionally, several
> retained MR tests were still using JUnit 4 conventions diverging from
> upstream Iceberg's modernized JUnit 5 test suite.
> *Proposed Changes*
> 1. Reuse Upstream Iceberg Test Jars & Remove Redundancies
> * Added {{test-jar}} dependencies for {{{}iceberg-data{}}},
> {{{}iceberg-api{}}}, and {{iceberg-core}} in {{iceberg/pom.xml}} and
> {{{}iceberg/iceberg-handler/pom.xml{}}}.
> * Removed 9 redundant test helper / utility files (~2,000 LOC eliminated):
> ** {{iceberg-catalog/.../TestHelpers.java}}
> ** {{iceberg-handler/.../data/DeleteReadTests.java}}
> ** {{iceberg-handler/.../data/FileHelpers.java}}
> ** {{iceberg-handler/.../data/GenericAppenderHelper.java}}
> ** {{iceberg-handler/.../data/IcebergGenerics2.java}} (replaced with
> upstream {{{}IcebergGenerics{}}})
> ** {{iceberg-handler/.../data/RandomGenericData.java}}
> ** {{iceberg-handler/.../util/RandomUtil.java}}
> ** {{iceberg-handler/.../util/TestCharSequenceSet.java}}
> ** {{iceberg-handler/.../util/TestLocationUtil.java}}
> 2. Modernize Retained MR Tests to JUnit 5 & Sync with Upstream
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
