[ 
https://issues.apache.org/jira/browse/HIVE-12750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15090615#comment-15090615
 ] 

Gopal V commented on HIVE-12750:
--------------------------------

The patch adds minimal performance impact (~8%), but after getting a simpler 
test-case, I've isolated some code which does not populate the isNull array and 
is triggering this particular issue.

A better approach to fixing this would be to maintain isNull correctly for a 
rare combination of FIL -> MJ -> FIL.

As a top level analysis, fixing HIVE-12824 or HIVE-12809 would end up fixing 
the symptoms again without fixing the root-cause.

I'll file a few more possible bugs which came up during a step through of the 
code.

> Vectorization logic not maintaining noNulls flag and isNull array properly 
> causing wrong query results
> ------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-12750
>                 URL: https://issues.apache.org/jira/browse/HIVE-12750
>             Project: Hive
>          Issue Type: Bug
>          Components: Hive
>            Reporter: Matt McCline
>            Assignee: Matt McCline
>            Priority: Critical
>         Attachments: HIVE-12750.1.patch, HIVE-12750.2.patch, 
> HIVE-12750.3.patch, HIVE-12750.4.patch, HIVE-12750.5.patch, 
> HIVE-12750.6.patch, HIVE-12750.8.patch
>
>
> A very large query produced wrong results due to not maintaining noNulls flag 
> and isNull array properly.  No Q file since input files too large.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to