[ 
https://issues.apache.org/jira/browse/HIVE-12820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15101834#comment-15101834
 ] 

Aihua Xu commented on HIVE-12820:
---------------------------------

Discussed with Chaoyu. Actually it's fine for such case.

When the file is in old format and escape=\\, \\\r will be unescaped properly 
to \r using the old logic.

The only case which could introduce the issue is when characters 'r' or 'n' are 
used as delimiters, the old format will be escape them into \\r or \\n and they 
will be incorrectly unescaped into \r or \n. But that seems to be extreme case. 
I will put that in the release notes.

> Remove the check if carriage return and new line are used for separator or 
> escape character
> -------------------------------------------------------------------------------------------
>
>                 Key: HIVE-12820
>                 URL: https://issues.apache.org/jira/browse/HIVE-12820
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 2.0.0, 2.1.0
>            Reporter: Aihua Xu
>            Assignee: Aihua Xu
>         Attachments: HIVE-12820.2.patch, HIVE-12820.patch
>
>
> The change in HIVE-11785 doesn't allow \r or \n to be used as separator or 
> escape character which may break some existing tables which uses \r as 
> separator or escape character e.g..
> This case actually can be supported regardless of SERIALIZATION_ESCAPE_CRLF 
> set or not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to