[
https://issues.apache.org/jira/browse/HIVE-12763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15106313#comment-15106313
]
Pengcheng Xiong commented on HIVE-12763:
----------------------------------------
Thanks [~alangates] for the comments that helped improve the patch. I have
addressed your comments accordingly as follows. (1) use optional rather than
required. (2) remove the configuration for bitvector as it is going to be used
only with HBase. (3) upgrade thrift to 0.9.3 and regenerate the code. The patch
becomes much smaller and readable. Please let me know if you need a separate
patch for non-generated code. (4) I store bit vector as strings because the
default serialization and de-serialization is Text (or String) in Hive. (5) I
noticed that javolution is already used by other components in Hive (e.g.,
./itests/qtest-accumulo/pom.xml:139: <artifactId>javolution</artifactId>)
In this case, is it necessary to add it to the NOTICE file again? Thanks!
> Use bit vector to track per partition NDV
> -----------------------------------------
>
> Key: HIVE-12763
> URL: https://issues.apache.org/jira/browse/HIVE-12763
> Project: Hive
> Issue Type: Improvement
> Reporter: Pengcheng Xiong
> Assignee: Pengcheng Xiong
> Attachments: HIVE-12763.01.patch, HIVE-12763.02.patch
>
>
> This will improve merging of per partitions stats.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
