[ 
https://issues.apache.org/jira/browse/HIVE-12777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15119153#comment-15119153
 ] 

Amareshwari Sriramadasu commented on HIVE-12777:
------------------------------------------------

[~prongs], Posted some comments on review board. Also check if any of the 
failure reported by pre-commit build are related to the patch. Run them in 
master make sure.

[~xuefuz], Agree with you : restoreSession on Hive Server crashes is more work 
and this jira is not doing that and It is doing a simple restore of the session 
handle. Let us know if you want any more to be added in this jira. This simple 
change would unblock us to move to hive master, and help move forward.

> Add capability to restore session in CLIService and SessionManager
> ------------------------------------------------------------------
>
>                 Key: HIVE-12777
>                 URL: https://issues.apache.org/jira/browse/HIVE-12777
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Rajat Khandelwal
>            Assignee: Rajat Khandelwal
>         Attachments: HIVE-12777.04.patch, HIVE-12777.08.patch, 
> HIVE-12777.09.patch, HIVE-12777.11.patch, HIVE-12777.12.patch, 
> HIVE-12777.13.patch, HIVE-12777.15.patch, HIVE-12777.16.patch, 
> HIVE-12777.17.patch
>
>
> Extensions using CLIService session handles should be able to restore the 
> session from the handle. 
> Apache Lens depends on a fork of hive and that fork has such a capability. 
> Functionality added: Restoring a session. A session opened once is lost once 
> the cli service is re-created. There may be some operation going on in that 
> session at the time the service is restarted. It's useful to be able to 
> restore a previously existing session. 
> Have added code in CLIService for that effect. Have also added a test class. 
> Relevant commit: 
> https://github.com/InMobi/hive/commit/931fe9116161a18952c082c14223ad6745fefe00#diff-0acb35f7cab7492f522b0c40ce3ce1be



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to