[ 
https://issues.apache.org/jira/browse/HIVE-12908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15125201#comment-15125201
 ] 

Chaoyu Tang commented on HIVE-12908:
------------------------------------

A question about this change
{code}
@@ -2723,7 +2721,10 @@ public static boolean moveFile(HiveConf conf, Path srcf, 
Path destf,
     try {
       if (inheritPerms || replace) {
         try{
-          destStatus = shims.getFullFileStatus(conf, destFs, 
destf.getParent());
+          destStatus = shims.getFullFileStatus(conf, destFs, destf);
+          if(destStatus.getFileStatus().isFile()) {                        
+            destStatus = shims.getFullFileStatus(conf, destFs, 
destf.getParent());
+          }
{code}
If the dest is a file, should not we preserve its initial permission instead to 
inherit its parent permission after it is replaced (renamed)?

> Improve dynamic partition loading III
> -------------------------------------
>
>                 Key: HIVE-12908
>                 URL: https://issues.apache.org/jira/browse/HIVE-12908
>             Project: Hive
>          Issue Type: Improvement
>          Components: Query Processor
>            Reporter: Ashutosh Chauhan
>            Assignee: Ashutosh Chauhan
>         Attachments: HIVE-12908.2.patch, HIVE-12908.3.patch, 
> HIVE-12908.4.patch, HIVE-12908.5.patch, HIVE-12908.patch
>
>
> Remove unnecessary Namenode calls.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to