[ 
https://issues.apache.org/jira/browse/HIVE-12679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15172392#comment-15172392
 ] 

Alan Gates commented on HIVE-12679:
-----------------------------------

I looked over the patch.  The code itself seems fine.  The question I have is 
about the approach.  There are several features tied into 
SessionHiveMetastoreClient and HiveMetastoreClient (temp tables, metastore 
hooks, how to connect to a remote metastore, as well as the new file footer 
cache).  

I'd like to better understand what flexibility you need.  If you just want to 
avoid connecting to the Thrift server that can be accomplished in the current 
code (e.g HS2 usually runs this way, the fast-path stuff in there runs this 
way).  Is there some feature you need there that can't be added to 
HIveMetastoreClient or SessionsHiveMetastoreClient?

> Allow users to be able to specify an implementation of IMetaStoreClient via 
> HiveConf
> ------------------------------------------------------------------------------------
>
>                 Key: HIVE-12679
>                 URL: https://issues.apache.org/jira/browse/HIVE-12679
>             Project: Hive
>          Issue Type: Improvement
>          Components: Configuration, Metastore, Query Planning
>    Affects Versions: 2.1.0
>            Reporter: Austin Lee
>            Assignee: Austin Lee
>            Priority: Minor
>              Labels: metastore
>         Attachments: HIVE-12679.1.patch, HIVE-12679.patch
>
>
> Hi,
> I would like to propose a change that would make it possible for users to 
> choose an implementation of IMetaStoreClient via HiveConf, i.e. 
> hive-site.xml.  Currently, in Hive the choice is hard coded to be 
> SessionHiveMetaStoreClient in org.apache.hadoop.hive.ql.metadata.Hive.  There 
> is no other direct reference to SessionHiveMetaStoreClient other than the 
> hard coded class name in Hive.java and the QL component operates only on the 
> IMetaStoreClient interface so the change would be minimal and it would be 
> quite similar to how an implementation of RawStore is specified and loaded in 
> hive-metastore.  One use case this change would serve would be one where a 
> user wishes to use an implementation of this interface without the dependency 
> on the Thrift server.
>   
> Thank you,
> Austin



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to