[
https://issues.apache.org/jira/browse/HIVE-12995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15184257#comment-15184257
]
Gopal V commented on HIVE-12995:
--------------------------------
LGTM - +1, pending minor comments left on RB (s/fileId/fileKey/ pretty much)
> LLAP: Synthetic file ids need collision checks
> ----------------------------------------------
>
> Key: HIVE-12995
> URL: https://issues.apache.org/jira/browse/HIVE-12995
> Project: Hive
> Issue Type: Bug
> Components: llap
> Affects Versions: 2.1.0
> Reporter: Gopal V
> Assignee: Sergey Shelukhin
> Attachments: HIVE-12995.01.patch, HIVE-12995.patch
>
>
> LLAP synthetic file ids do not have any way of checking whether a collision
> occurs other than a data-error.
> Synthetic file-ids have only been used with unit tests so far - but they will
> be needed to add cache mechanisms to non-HDFS filesystems.
> In case of Synthetic file-ids, it is recommended that we track the full-tuple
> (path, mtime, len) in the cache so that a cache-hit for the synthetic file-id
> can be compared against the parameters & only accepted if those match.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
