[ 
https://issues.apache.org/jira/browse/HIVE-12439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15205954#comment-15205954
 ] 

Lefty Leverenz commented on HIVE-12439:
---------------------------------------

Doc note:  This adds three configuration parameters 
(*hive.direct.sql.max.query.length*, *hive.direct.sql.max.elements.in.clause*, 
and *hive.direct.sql.max.elements.values.clause*) to HiveConf.java in releases 
1.3.0 and 2.1.0, so they need to be documented in the wiki.

* [Configuration Properties -- MetaStore | 
https://cwiki.apache.org/confluence/display/Hive/Configuration+Properties#ConfigurationProperties-MetaStore]
* [Configuration Properties -- Query and DDL Execution | 
https://cwiki.apache.org/confluence/display/Hive/Configuration+Properties#ConfigurationProperties-QueryandDDLExecution]

Do they belong in the MetaStore section or the general section for query 
execution?  (Clues:  Their all-caps equivalents have METASTORE_ prefixes and 
the MetaStore section already includes *hive.metastore.try.direct.sql* and 
*hive.metastore.try.direct.sql.ddl*.)

[~ekoifman], all three parameter names imply that they only pertain to direct 
SQL, although their descriptions don't mention direct SQL so they sound more 
global.  Should the wiki descriptions clarify that?

> CompactionTxnHandler.markCleaned() and TxnHandler.openTxns() misc improvements
> ------------------------------------------------------------------------------
>
>                 Key: HIVE-12439
>                 URL: https://issues.apache.org/jira/browse/HIVE-12439
>             Project: Hive
>          Issue Type: Improvement
>          Components: Metastore, Transactions
>    Affects Versions: 1.0.0
>            Reporter: Eugene Koifman
>            Assignee: Wei Zheng
>              Labels: TODOC1.3, TODOC2.1
>             Fix For: 1.3.0, 2.1.0
>
>         Attachments: HIVE-12439.1.patch, HIVE-12439.2.patch, 
> HIVE-12439.3.patch
>
>
> # add a safeguard to make sure IN clause is not too large; break up by txn id 
> to delete from TXN_COMPONENTS where tc_txnid in ...
> # TxnHandler. openTxns() - use 1 insert with many rows in values() clause, 
> rather than 1 DB roundtrip per row



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to