[ 
https://issues.apache.org/jira/browse/HIVE-12968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15209033#comment-15209033
 ] 

Jesus Camacho Rodriguez commented on HIVE-12968:
------------------------------------------------

I think even if the original case for this patch is covered in Calcite, it 
would be still useful for readability of predicates in plans.

E.g.
{noformat}
predicate: (((date is not null and dealid is not null) and cityid is not null) 
and userid is not null) (type: boolean)
{noformat}
becomes:
{noformat}
predicate: (date is not null and dealid is not null and cityid is not null and 
userid is not null) (type: boolean)
{noformat}

> genNotNullFilterForJoinSourcePlan: needs to merge predicates into the 
> multi-AND
> -------------------------------------------------------------------------------
>
>                 Key: HIVE-12968
>                 URL: https://issues.apache.org/jira/browse/HIVE-12968
>             Project: Hive
>          Issue Type: Improvement
>          Components: Logical Optimizer
>    Affects Versions: 2.1.0
>            Reporter: Gopal V
>            Assignee: Gopal V
>            Priority: Minor
>         Attachments: HIVE-12968.1.patch, HIVE-12968.2.patch
>
>
> {code}
> predicate: ((cbigint is not null and cint is not null) and cint BETWEEN 
> 1000000 AND 3000000) (type: boolean)
> {code}
> does not fold the IS_NULL on cint, because of the structure of the AND clause.
> For example, see {{tez_dynpart_hashjoin_1.q}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to