[
https://issues.apache.org/jira/browse/HIVE-11793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wei Zheng updated HIVE-11793:
-----------------------------
Attachment: HIVE-11793.3.patch
patch 3 for test.
1. I think it should be fine to change the interface, since hive metastore is
solely used by hive client (afaik:). [~sushanth] may comment on that.
2. I looked at the doc and think the behavior is: if the user omits the db part
(SHOW LOCKS table), then we should show locks for current database. If user
just issues SHOW LOCKS, without any filter option, then we should show all the
locks, just as what we do currently.
https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DDL#LanguageManualDDL-ShowLocks
3. I added JUnit test in TestDbTxnManager.
> SHOW LOCKS with DbTxnManager ignores filter options
> ---------------------------------------------------
>
> Key: HIVE-11793
> URL: https://issues.apache.org/jira/browse/HIVE-11793
> Project: Hive
> Issue Type: Improvement
> Components: Transactions
> Affects Versions: 1.0.0
> Reporter: Eugene Koifman
> Assignee: Wei Zheng
> Priority: Minor
> Attachments: HIVE-11793.1.patch, HIVE-11793.2.patch,
> HIVE-11793.3.patch
>
>
> https://cwiki.apache.org/confluence/display/Hive/Locking and
> https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DDL#LanguageManualDDL-ShowLocks
> list various options that can be used with SHOW LOCKS, e.g. <TABLE>
> When ACID is enabled, all these options are ignored and a full list is
> returned.
> (also only ext lock id is shown, int lock id is not).
> see DDLTask.showLocks() and TxnHandler.showLocks()
> requires extending ShowLocksRequest which is a Thrift object
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
