[ 
https://issues.apache.org/jira/browse/HIVE-13068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15261863#comment-15261863
 ] 

Jesus Camacho Rodriguez commented on HIVE-13068:
------------------------------------------------

[~ashutoshc], I think patch is ready to review; probably I will need to update 
a few files when QA comes back.

I extended current logic to cover major regressions, but I left four issues for 
the follow-up, as the patch was growing rather large and they seem independent 
extensions to this work:
- Transform NVL to CASE (HIVE-13637). Regression can be seen in 
constantPropWhen.q
- Rule to pull up constants through Limit (HIVE-13638). Regression can be seen 
in input26.q
- Rule to pull up constants through Union (HIVE-13639). Regression can be seen 
in union_view.q
- Bring PartitionConditionRemover to Calcite (HIVE-13640). Regression can be 
seen in index_auto_unused.q

In turn, the extensions that I added to HiveRexUtil will be in Calcite 1.8.0 
(CALCITE-1220), thus it will be removed once we upgrade to the newest Calcite 
version.

> Disable Hive ConstantPropagate optimizer when CBO has optimized the plan II
> ---------------------------------------------------------------------------
>
>                 Key: HIVE-13068
>                 URL: https://issues.apache.org/jira/browse/HIVE-13068
>             Project: Hive
>          Issue Type: Sub-task
>          Components: CBO, Logical Optimizer
>    Affects Versions: 2.1.0
>            Reporter: Jesus Camacho Rodriguez
>            Assignee: Jesus Camacho Rodriguez
>         Attachments: HIVE-13068.01.patch, HIVE-13068.01.patch, 
> HIVE-13068.02.patch, HIVE-13068.patch
>
>
> After HIVE-12543 went in, we need follow-up work to disable the last call to 
> ConstantPropagate in Hive. This probably implies work on extending the 
> constant folding logic in Calcite.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to