[ 
https://issues.apache.org/jira/browse/HIVE-13964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15323067#comment-15323067
 ] 

Abdullah Yousufi edited comment on HIVE-13964 at 6/9/16 6:42 PM:
-----------------------------------------------------------------

Thanks for the review, [~spena].

1. Fixed:
{code}
if (propertyFile != null) {
    dispatch("!properties " + propertyFile);
}
{code}

2. That's strange, because I just tried that case and this was my output:
{code}
$ ./beeline --property-file
Missing argument for option: property-file
Usage: java org.apache.hive.cli.beeline.BeeLine 
   -u <database url>               the JDBC URL to connect to
...
{code}
Could you try another parameter without any arguments, such as --hiveconf and 
see if it prints out the "Missing argument..." error for that?

3. Added a fix for this to exit, but can undo this if necessary.

Let me know about points 2 and 3, and then I can upload another patch.


was (Author: ayousufi):
Thanks for the review, Sergio.

1. Fixed:
{code}
if (propertyFile != null) {
    dispatch("!properties " + propertyFile);
}
{code}

2. That's strange, because I just tried that case and this was my output:
{code}
$ ./beeline --property-file
Missing argument for option: property-file
Usage: java org.apache.hive.cli.beeline.BeeLine 
   -u <database url>               the JDBC URL to connect to
...
{code}
Could you try another parameter without any arguments, such as --hiveconf and 
see if it prints out the "Missing argument..." error for that?

3. Added a fix for this to exit, but can undo this if necessary.

Let me know about points 2 and 3, and then I can upload another patch.

> Add a parameter to beeline to allow a properties file to be passed in
> ---------------------------------------------------------------------
>
>                 Key: HIVE-13964
>                 URL: https://issues.apache.org/jira/browse/HIVE-13964
>             Project: Hive
>          Issue Type: New Feature
>          Components: Beeline
>    Affects Versions: 2.0.1
>            Reporter: Abdullah Yousufi
>            Assignee: Abdullah Yousufi
>            Priority: Minor
>             Fix For: 2.2.0
>
>         Attachments: HIVE-13964.01.patch
>
>
> HIVE-6652 removed the ability to pass in a properties file as a beeline 
> parameter. It may be a useful feature to be able to pass the file in is a 
> parameter, such as --property-file.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to