[
https://issues.apache.org/jira/browse/HIVE-13883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15378769#comment-15378769
]
Thejas M Nair commented on HIVE-13883:
--------------------------------------
Patch looks good.
Only one change I would recommend, replacing -
String checksumStr = new
StringBuilder().append(tokenPath.getParent()).append(File.separator).append(".").append(tokenPath.getName()).append(".crc").toString();
with more readable
String checksumStr = tokenPath.getParent() + File.separator + "." +
tokenPath.getName() + ".crc";
Java compiler would automatically use StringBuilder for such simple cases.
> WebHCat leaves token crc file never gets deleted
> ------------------------------------------------
>
> Key: HIVE-13883
> URL: https://issues.apache.org/jira/browse/HIVE-13883
> Project: Hive
> Issue Type: Bug
> Components: WebHCat
> Affects Versions: 1.2.0, 1.1.1, 1.2.1, 2.0.1
> Reporter: niklaus xiao
> Priority: Minor
> Attachments: HIVE-13883.patch
>
>
> In one of our long run environment, there are thousands of
> /tmp/.templeton*.tmp.crc files,
> {quote}
> omm@szxciitslx17645:/> ll /tmp/.templeton*.tmp.crc
> ...
> -rw-r--r-- 1 omm wheel 12 May 26 18:15
> /tmp/.templeton6676048390600607654.tmp.crc
> -rw-r--r-- 1 omm wheel 12 May 26 18:14
> /tmp/.templeton2733383617337556503.tmp.crc
> -rw-r--r-- 1 omm wheel 12 May 26 18:12
> /tmp/.templeton2183121761801669064.tmp.crc
> -rw-r--r-- 1 omm wheel 12 May 26 18:11
> /tmp/.templeton2689764046140543879.tmp.crc
> ...
> {quote}
> {quote}
> omm@szxciitslx17645:/> ll /tmp/.templeton*.tmp.crc | wc -l
> 17986
> {quote}
> It's created by webhcat,
> [https://github.com/apache/hive/blob/master/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/SecureProxySupport.java#L193]
> and never gets deleted
> [https://github.com/apache/hive/blob/master/hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/SecureProxySupport.java#L110]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
