[
https://issues.apache.org/jira/browse/HIVE-14039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15425309#comment-15425309
]
Vaibhav Gumashta commented on HIVE-14039:
-----------------------------------------
[~ziyangz] Thanks for the patch. Just went over the changes and here's my
feedback:
I think all the information that we need (config, version number, file format,
whether the query is from HS2) to decide whether ThriftJDBCBinarySerde will get
used is available to us during opening of a session on HS2 (HiveSessionImpl).
How about we make this decision while opening a session in HS2 and simply set a
boolean in SessionState. The boolean value can later be used to appropriately
configure the logical plan in SemanticAnalyzer and physical plan in
TaskCompiler. This will simplify code and also avoid the need for
SematicAnalyzer & TaskCompiler to depend on service-rpc.
> HiveServer2: Make the usage of server with JDBC thirft serde enabled,
> backward compatible for older clients
> -----------------------------------------------------------------------------------------------------------
>
> Key: HIVE-14039
> URL: https://issues.apache.org/jira/browse/HIVE-14039
> Project: Hive
> Issue Type: Sub-task
> Components: HiveServer2, JDBC
> Affects Versions: 2.0.1
> Reporter: Vaibhav Gumashta
> Assignee: Ziyang Zhao
> Attachments: HIVE-14039.2.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
