[jira] [Commented] (HIVE-13589) beeline - support prompt for password with '-u' option

[Vihang Karajgaonkar (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HIVE-13589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15437261#comment-15437261
 ] 

Vihang Karajgaonkar commented on HIVE-13589:
--------------------------------------------

Thanks [~Ke Jia] for the patch. Couple of comments below:

1. I think there is a method called 
{noformat}
public ConsoleReader getConsoleReader(InputStream inputStream) throws 
IOException
{noformat}

in BeeLine.java. I would suggest using this method to initialize the console 
reader in the begin method before beeline initializes using the args.
{noformat}
try {
      if (isBeeLine) {
        int code = initArgs(args);
        if (code != 0) {
          return code;
        }
...
{noformat}

2. Will this work if if the password is really an empty string (non-null but 
empty)?

> beeline - support prompt for password with '-u' option
> ------------------------------------------------------
>
>                 Key: HIVE-13589
>                 URL: https://issues.apache.org/jira/browse/HIVE-13589
>             Project: Hive
>          Issue Type: Bug
>          Components: Beeline
>            Reporter: Thejas M Nair
>            Assignee: Ke Jia
>         Attachments: HIVE-13589.1.patch, HIVE-13589.2.patch, 
> HIVE-13589.3.patch, HIVE-13589.4.patch
>
>
> Specifying connection string using commandline options in beeline is 
> convenient, as it gets saved in shell command history, and it is easy to 
> retrieve it from there.
> However, specifying the password in command prompt is not secure as it gets 
> displayed on screen and saved in the history.
> It should be possible to specify '-p' without an argument to make beeline 
> prompt for password.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)