[
https://issues.apache.org/jira/browse/HIVE-14690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15469584#comment-15469584
]
Tao Li commented on HIVE-14690:
-------------------------------
I have 2 more comments:
1. Should we set startSs.isStarted to true by the end of the method? If
exceptions are thrown during the middle, we probably don't want to set it to
true.
2. I think we can add a synchronization block after the if (startSs.isStarted)
check to improve performance (vs the synchronized method). We don't need to
enter the monitor to check the flag. Inside the monitor, we can double check
the flag (return if the isStarted has been set to true).
> Query fail when hive.exec.parallel=true, with conflicting session dir
> ---------------------------------------------------------------------
>
> Key: HIVE-14690
> URL: https://issues.apache.org/jira/browse/HIVE-14690
> Project: Hive
> Issue Type: Bug
> Affects Versions: 1.3.0, 2.1.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Attachments: HIVE-14690.1.patch, HIVE-14690.2.patch,
> HIVE-14690.3.patch
>
>
> This happens when hive.scratchdir.lock=true. Error message:
> {code}
> /hive/scratch/343hdirdp/cab907fc-5e1d-4d69-aa72-d7b442495c7a/inuse.info
> (inode 19537): File does not exist. [Lease. Holder:
> DFSClient_NONMAPREDUCE_1572639975_1, pendingcreates: 2]
> at
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem.checkLease(FSNamesystem.java:3430)
> at
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem.analyzeFileState(FSNamesystem.java:3235)
> at
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getNewBlockTargets(FSNamesystem.java:3073)
> at
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getAdditionalBlock(FSNamesystem.java:3033)
> at
> org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.addBlock(NameNodeRpcServer.java:725)
> at
> org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolServerSideTranslatorPB.addBlock(ClientNamenodeProtocolServerSideTranslatorPB.java:492)
> at
> org.apache.hadoop.hdfs.protocol.proto.ClientNamenodeProtocolProtos$ClientNamenodeProtocol$2.callBlockingMethod(ClientNamenodeProtocolProtos.java)
> at
> org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:616)
> at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:969)
> at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2137)
> at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2133)
> at java.security.AccessController.doPrivileged(Native Method)
> at javax.security.auth.Subject.doAs(Subject.java:415)
> at
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1668)
> at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2131)
> at
> org.apache.hadoop.hive.ql.session.SessionState.start(SessionState.java:535)
> at org.apache.hadoop.hive.ql.exec.TaskRunner.run(TaskRunner.java:74)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
