[ 
https://issues.apache.org/jira/browse/HIVE-14717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15472244#comment-15472244
 ] 

Vihang Karajgaonkar commented on HIVE-14717:
--------------------------------------------

I investigated this more. I think we can satisfy the requirement in HIVE-13589 
without breaking any backwards compatibility by making the password option 
"optional" using the OptionBuilder. That way we are not breaking backwards 
compatibility since we are widening the scope of the option. So 
{noformat}beeline -u url -n user -p pass{noformat} {noformat}beeline -u url -p 
-n user{noformat} and {noformat}beeline -u url -n user -p{noformat} will work.

If the user provides -p on the commandline the user can provide the password on 
the commandline like current behavior or choose not provide password. In that 
case Beeline will prompt for the password. So following cases should 
successfully connect without prompting any password (assuming the 
authentication mode is default) to make sure it is backwards compatible.

{noformat}
beeline -u url -n user -p pass
beeline -u url -p pass -n user
beeline -u url
beeline -u url -n user
beeline -u url -p password
beeline -u 
"jdbc:hive2://localhost:10000/default;user=username;password=password"
beeline -u "jdbc:hive2://"
{noformat}

In case the user does not want the password to be seen on the command line or 
command history he/she can issue the following way to connect and beeline will 
prompt for password in each case below

{noformat}
beeline -u url -n user -p
beeline -u url -p -n user
beeline -p -u url -n user
beeline -u url -p
beeline -u url -p -n user -e "show tables;"
{noformat}

I have done some testing and it is working as expected. [~Ferd] Let me know if 
you have any thoughts?

> Beeline tests failing
> ---------------------
>
>                 Key: HIVE-14717
>                 URL: https://issues.apache.org/jira/browse/HIVE-14717
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Vihang Karajgaonkar
>            Assignee: Vihang Karajgaonkar
>            Priority: Critical
>
> If you run mvn clean test in beeline you see the following errors:
> {noformat}
> -------------------------------------------------------
>  T E S T S
> -------------------------------------------------------
> Running org.apache.hive.beeline.cli.TestHiveCli
> Running org.apache.hive.beeline.TestBeelineArgParsing
> Tests run: 32, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.584 sec - 
> in org.apache.hive.beeline.TestBeelineArgParsing
> Running org.apache.hive.beeline.TestBeeLineHistory
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.198 sec - 
> in org.apache.hive.beeline.TestBeeLineHistory
> Running org.apache.hive.beeline.TestBeeLineOpts
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.338 sec - 
> in org.apache.hive.beeline.TestBeeLineOpts
> Running org.apache.hive.beeline.TestBufferedRows
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.382 sec - 
> in org.apache.hive.beeline.TestBufferedRows
> Running org.apache.hive.beeline.TestClientCommandHookFactory
> Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.546 sec - 
> in org.apache.hive.beeline.TestClientCommandHookFactory
> Running org.apache.hive.beeline.TestIncrementalRowsWithNormalization
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.379 sec - 
> in org.apache.hive.beeline.TestIncrementalRowsWithNormalization
> Running org.apache.hive.beeline.TestTableOutputFormat
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.402 sec - 
> in org.apache.hive.beeline.TestTableOutputFormat
> Results :
> Tests run: 44, Failures: 0, Errors: 0, Skipped: 0
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Total time: 01:03 min
> [INFO] Finished at: 2016-09-07T10:57:28-07:00
> [INFO] Final Memory: 65M/949M
> [INFO] 
> ------------------------------------------------------------------------
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on 
> project hive-beeline: ExecutionException The forked VM terminated without 
> properly saying goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd 
> /Users/vihang/work/src/upstream/hive/beeline && 
> /Library/Java/JavaVirtualMachines/jdk1.7.0_79.jdk/Contents/Home/jre/bin/java 
> -Xmx2048m -XX:MaxPermSize=512m -jar 
> /Users/vihang/work/src/upstream/hive/beeline/target/surefire/surefirebooter8133887423099901737.jar
>  
> /Users/vihang/work/src/upstream/hive/beeline/target/surefire/surefire6528142441948588259tmp
>  
> /Users/vihang/work/src/upstream/hive/beeline/target/surefire/surefire_05570572112194455658tmp
> [ERROR] -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
> {noformat}
> My guess is this is related to recent fix for HIVE-13589 but needs more 
> investigation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to