[
https://issues.apache.org/jira/browse/HIVE-14775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15526800#comment-15526800
]
Mohit Sabharwal commented on HIVE-14775:
----------------------------------------
Thanks, [~zsombor.klara], this looks like a useful cleanup!
Couple minor comments on RB.
Looks ok to trickle JMException all the way to the top instead
of wrapping it inside IOException since MetricsMBean extends a JMX interface.
cc [~szehon] in case he has any comments
> Investigate IOException usage in Metrics APIs
> ---------------------------------------------
>
> Key: HIVE-14775
> URL: https://issues.apache.org/jira/browse/HIVE-14775
> Project: Hive
> Issue Type: Sub-task
> Components: Hive, HiveServer2, Metastore
> Reporter: Barna Zsombor Klara
> Assignee: Barna Zsombor Klara
>
> A large number of metrics APIs seem to declare to throw IOExceptions
> needlessly. (incrementCounter, decrementCounter etc.)
> This is not only misleading but it fills up the code with unnecessary catch
> blocks never to be reached.
> We should investigate if these exceptions are thrown at all, and remove them
> if it is truly unused.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
