[ 
https://issues.apache.org/jira/browse/HIVE-15051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15648050#comment-15648050
 ] 

Peter Vary commented on HIVE-15051:
-----------------------------------

I think we have to think about which plugin to turn on, so we get valuable help 
for the resources we spend.
Here are the running times that I have measured:

The run times are when the change is in beeline in seconds:
- maven install: 28 + 26
- checkstyle: ?
- findbugs: 30 + 30
- javadoc: 17 + 16
- cleanup: 11
- rat: 20

Total time: ~ 4 mins

--------------------------------------------------------------------
The same patch when the change is in ql:
- maven install: 75 + 90
- checkstyle: ?
- findbugs: 107 + 124 - failed because of memory, so needs some tweaking
- javadoc: 45 + 48 - failed because of the wrong javadoc comments
- cleanup: 17
- rat: 26

Total time: ~10 mins

> Test framework integration with findbugs, rat checks etc.
> ---------------------------------------------------------
>
>                 Key: HIVE-15051
>                 URL: https://issues.apache.org/jira/browse/HIVE-15051
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Testing Infrastructure
>            Reporter: Peter Vary
>            Assignee: Peter Vary
>
> Find a way to integrate code analysis tools like findbugs, rat checks to 
> PreCommit tests, thus removing the burden from reviewers to check the code 
> style and other checks which could be done by code. 
> Might worth to take a look on Yetus, but keep in mind the Hive has a specific 
> parallel test framework.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to