[ https://issues.apache.org/jira/browse/HIVE-14902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15656114#comment-15656114 ]
Hive QA commented on HIVE-14902: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12838450/HIVE-14902.2.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 3 failed/errored test(s), 10637 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[join_acid_non_acid] (batchId=150) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[union_fast_stats] (batchId=145) org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainanalyze_2] (batchId=91) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/2074/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/2074/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-2074/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 3 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12838450 - PreCommit-HIVE-Build > HiveServer2: Cleanup code which checks for ThriftJDBCSerde usage > ---------------------------------------------------------------- > > Key: HIVE-14902 > URL: https://issues.apache.org/jira/browse/HIVE-14902 > Project: Hive > Issue Type: Sub-task > Components: HiveServer2, JDBC, ODBC > Affects Versions: 2.1.0 > Reporter: Vaibhav Gumashta > Assignee: Ziyang Zhao > Attachments: HIVE-14902.2.patch > > > As part of HIVE-14039, we simplified the condition checking by setting a > boolean in SessionState (from HiveSessionImpl) and then using that in other > layers to decide whether we should use ThriftJDBCSerde. However, there are > some parts of the code (e.g. FileSinkOperator.closeOp, Driver.getResults, > SQLOperation.getNextRowSet) where the condition checking is still complicated > - we should refactor that. -- This message was sent by Atlassian JIRA (v6.3.4#6332)