[
https://issues.apache.org/jira/browse/HIVE-15675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15831885#comment-15831885
]
Peter Vary commented on HIVE-15675:
-----------------------------------
[~jun.he]: Thanks for finding this issue! The patch looks good to me. Just some
minor nits:
- The table could be deleted with h.dropTable("foo"), and the partitions will
be deleted automatically
- There should be a newline between the end of the init method, and before the
deInit method to adhere the coding conventions
(https://cwiki.apache.org/confluence/display/Hive/HowToContribute#HowToContribute-CodingConventions)
Otherwise the patch looks good to me.
Thanks,
Peter
> ql.hooks.TestQueryHooks failure
> -------------------------------
>
> Key: HIVE-15675
> URL: https://issues.apache.org/jira/browse/HIVE-15675
> Project: Hive
> Issue Type: Bug
> Components: Tests
> Reporter: Jun He
> Assignee: Jun He
> Attachments: HIVE-15675.0.patch
>
>
> ql.parse.TestQBCompact creates table "foo" in initialization but doesn't
> clean it after its testcases are finished. This will cause
> ql.hooks.TestQueryHooks::testCompileFailure failed as testCompileFailure
> expects that "foo" doesn't exist.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
