[ https://issues.apache.org/jira/browse/HIVE-10562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15832240#comment-15832240 ]
Hive QA commented on HIVE-10562: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12848355/HIVE-10562.3.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 16 failed/errored test(s), 10950 tests executed *Failed tests:* {noformat} TestDerbyConnector - did not produce a TEST-*.xml file (likely timed out) (batchId=235) TestSparkCliDriver - did not produce a TEST-*.xml file (likely timed out) (batchId=125) [table_access_keys_stats.q,bucketmapjoin11.q,auto_join4.q,mapjoin_decimal.q,join34.q,nullgroup.q,mergejoins_mixed.q,sort.q,stats8.q,auto_join28.q,join17.q,union17.q,skewjoinopt11.q,groupby1_map.q,load_dyn_part11.q] org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[specialChar] (batchId=22) org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver[encryption_join_with_different_encryption_keys] (batchId=159) org.apache.hadoop.hive.cli.TestHBaseNegativeCliDriver.testCliDriver[cascade_dbdrop] (batchId=226) org.apache.hadoop.hive.cli.TestHBaseNegativeCliDriver.testCliDriver[generatehfiles_require_family_path] (batchId=226) org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[orc_ppd_schema_evol_3a] (batchId=136) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[escape1] (batchId=139) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[escape2] (batchId=154) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_text_vec_part] (batchId=149) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_if_expr] (batchId=140) org.apache.hadoop.hive.cli.TestNegativeMinimrCliDriver.testCliDriver[cluster_tasklog_retrieval] (batchId=87) org.apache.hadoop.hive.cli.TestNegativeMinimrCliDriver.testCliDriver[minimr_broken_pipe] (batchId=87) org.apache.hive.beeline.TestSchemaTool.testSchemaUpgrade (batchId=211) org.apache.hive.jdbc.TestJdbcDriver2.testSelectExecAsync2 (batchId=215) org.apache.hive.jdbc.TestMultiSessionsHS2WithLocalClusterSpark.testSparkQuery (batchId=217) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/3071/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/3071/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-3071/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 16 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12848355 - PreCommit-HIVE-Build > Add version column to NOTIFICATION_LOG table and DbNotificationListener > ----------------------------------------------------------------------- > > Key: HIVE-10562 > URL: https://issues.apache.org/jira/browse/HIVE-10562 > Project: Hive > Issue Type: Sub-task > Components: Import/Export > Affects Versions: 1.2.0 > Reporter: Sushanth Sowmyan > Assignee: Sushanth Sowmyan > Attachments: HIVE-10562.2.patch, HIVE-10562.3.patch, HIVE-10562.patch > > > Currently, we have a JSON encoded message being stored in the > NOTIFICATION_LOG table. > If we want to be future proof, we need to allow for versioning of this > message, since we might change what gets stored in the message. A prime > example of what we'd want to change is as in HIVE-10393. > MessageFactory already has stubs to allow for versioning of messages, and we > could expand on this further in the future. NotificationListener currently > encodes the message version into the header for the JMS message it sends, > which seems to be the right place for a message version (instead of being > contained in the message, for eg.). > So, we should have a similar ability for DbEventListener as well, and the > place this makes the most sense is to and add a version column to the > NOTIFICATION_LOG table. -- This message was sent by Atlassian JIRA (v6.3.4#6332)