[
https://issues.apache.org/jira/browse/HIVE-15671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15832257#comment-15832257
]
Marcelo Vanzin commented on HIVE-15671:
---------------------------------------
bq. I got a different problem when the driver suddenly dies (due to OOM, for
instance) ... Hive wouldn't detect the driver was gone until 10m later.
If you mean it dies before the SASL handshake is complete, then in that case
maybe my understanding that the server timeout applies to the whole connection
+ handshake is wrong and that should be fixed. i.e. the timeout set up in
{{registerClient}} should apply to the whole handshake and not only until
there's a connection.
But if it dies after the SASL handshake, then it seems like the problem is
somewhere else and shouldn't really be related to either of these timeouts.
> RPCServer.registerClient() erroneously uses server/client handshake timeout
> for connection timeout
> --------------------------------------------------------------------------------------------------
>
> Key: HIVE-15671
> URL: https://issues.apache.org/jira/browse/HIVE-15671
> Project: Hive
> Issue Type: Bug
> Components: Spark
> Affects Versions: 1.1.0
> Reporter: Xuefu Zhang
> Assignee: Xuefu Zhang
> Attachments: HIVE-15671.patch
>
>
> {code}
> /**
> * Tells the RPC server to expect a connection from a new client.
> * ...
> */
> public Future<Rpc> registerClient(final String clientId, String secret,
> RpcDispatcher serverDispatcher) {
> return registerClient(clientId, secret, serverDispatcher,
> config.getServerConnectTimeoutMs());
> }
> {code}
> {{config.getServerConnectTimeoutMs()}} returns value for
> *hive.spark.client.server.connect.timeout*, which is meant for timeout for
> handshake between Hive client and remote Spark driver. Instead, the timeout
> should be *hive.spark.client.connect.timeout*, which is for timeout for
> remote Spark driver in connecting back to Hive client.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
