[ 
https://issues.apache.org/jira/browse/HIVE-15969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Thejas M Nair updated HIVE-15969:
---------------------------------
    Description: 

Looks like the additional failures in TestRemoteHiveMetaStore, 
TestSetUGIOnOnlyServer
 are related to this patch in HIVE-15877. 
I don't think that change was intended.

{code}
--- metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
+++ metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
@@ -739,7 +739,10 @@ public void createTable(Table tbl, EnvironmentContext 
envContext) throws Already
         hook.commitCreateTable(tbl);
       }
       success = true;
-    } finally {
+    } catch (Exception e){
+      LOG.error("Got exception from createTable", e);
+    }
+    finally {
       if (!success && (hook != null)) {
         hook.rollbackCreateTable(tbl);
       }

{code}

  was:
Pasting comment from HIVE-15877

[~ashutoshc] [~bslim]
Looks like the additional failures in the unit tests seen here are related to 
this patch. I will create a new jira. Is that change needed ?

{code}
--- metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
+++ metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
@@ -739,7 +739,10 @@ public void createTable(Table tbl, EnvironmentContext 
envContext) throws Already
         hook.commitCreateTable(tbl);
       }
       success = true;
-    } finally {
+    } catch (Exception e){
+      LOG.error("Got exception from createTable", e);
+    }
+    finally {
       if (!success && (hook != null)) {
         hook.rollbackCreateTable(tbl);
       }

{code}


> Failures in TestRemoteHiveMetaStore, TestSetUGIOnOnlyServer
> -----------------------------------------------------------
>
>                 Key: HIVE-15969
>                 URL: https://issues.apache.org/jira/browse/HIVE-15969
>             Project: Hive
>          Issue Type: Sub-task
>    Affects Versions: 2.2.0
>            Reporter: Thejas M Nair
>
> Looks like the additional failures in TestRemoteHiveMetaStore, 
> TestSetUGIOnOnlyServer
>  are related to this patch in HIVE-15877. 
> I don't think that change was intended.
> {code}
> --- 
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
> +++ 
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
> @@ -739,7 +739,10 @@ public void createTable(Table tbl, EnvironmentContext 
> envContext) throws Already
>          hook.commitCreateTable(tbl);
>        }
>        success = true;
> -    } finally {
> +    } catch (Exception e){
> +      LOG.error("Got exception from createTable", e);
> +    }
> +    finally {
>        if (!success && (hook != null)) {
>          hook.rollbackCreateTable(tbl);
>        }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to