[ https://issues.apache.org/jira/browse/HIVE-15891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15873928#comment-15873928 ]
Hive QA commented on HIVE-15891: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12853503/HIVE-15891.4.patch {color:green}SUCCESS:{color} +1 due to 3 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 9 failed/errored test(s), 10249 tests executed *Failed tests:* {noformat} TestDerbyConnector - did not produce a TEST-*.xml file (likely timed out) (batchId=235) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[cbo_rp_auto_join1] (batchId=3) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[interval_arithmetic] (batchId=43) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[join31] (batchId=81) org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver[encryption_join_with_different_encryption_keys] (batchId=159) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[multiMapJoin2] (batchId=152) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query14] (batchId=223) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[join31] (batchId=133) org.apache.hive.beeline.TestBeeLineWithArgs.testQueryProgressParallel (batchId=211) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/3653/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/3653/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-3653/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 9 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12853503 - PreCommit-HIVE-Build > Detect query rewrite scenario for UPDATE/DELETE/MERGE and fail fast > ------------------------------------------------------------------- > > Key: HIVE-15891 > URL: https://issues.apache.org/jira/browse/HIVE-15891 > Project: Hive > Issue Type: Bug > Components: Transactions > Affects Versions: 2.2.0 > Reporter: Wei Zheng > Assignee: Wei Zheng > Attachments: HIVE-15891.1.patch, HIVE-15891.2.patch, > HIVE-15891.3.patch, HIVE-15891.4.patch > > > Currently ACID UpdateDeleteSemanticAnalyzer directly manipulates the AST tree > but it's different from the general approach of modifying the token stream > and thus will cause AST tree mismatch if there is any rewrite happening after > UpdateDeleteSemanticAnalyzer. > The long term solution will be to rewrite the AST handling logic in > UpdateDeleteSemanticAnalyzer, to make it consistent with the general approach. > This ticket will for now detect the error prone cases and fail early. -- This message was sent by Atlassian JIRA (v6.3.15#6346)