[ 
https://issues.apache.org/jira/browse/HIVE-1626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Teddy Choi updated HIVE-1626:
-----------------------------
    Attachment: HIVE-1626.2.patch

125 files are changed. Most of files are subclasses of NodeProcessor and 
Dispatcher. They now use Deque instead of Stack. However, there were dozens of 
Stack.get(int) calls, which is not in ArrayDeque. I implemented 
Utils.get(Deque, int) for it with Deque.decendingIterator(), which impacts GC.

> stop using java.util.Stack
> --------------------------
>
>                 Key: HIVE-1626
>                 URL: https://issues.apache.org/jira/browse/HIVE-1626
>             Project: Hive
>          Issue Type: Improvement
>          Components: Query Processor
>    Affects Versions: 0.7.0
>            Reporter: John Sichi
>            Assignee: Teddy Choi
>         Attachments: HIVE-1626.2.patch
>
>
> We currently use Stack as part of the generic node walking library.  Stack 
> should not be used for this since its inheritance from Vector incurs 
> superfluous synchronization overhead.
> Most projects end up adding an ArrayStack implementation and using that 
> instead.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to