[ 
https://issues.apache.org/jira/browse/HIVE-1626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15877679#comment-15877679
 ] 

Hive QA commented on HIVE-1626:
-------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12853867/HIVE-1626.2.patch

{color:red}ERROR:{color} -1 due to build exiting with an error

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/3686/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/3686/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-3686/

Messages:
{noformat}
**** This message was trimmed, see log for full details ****
Apply anyway? [n] 
Skipping patch.
3 out of 3 hunks ignored -- saving rejects to file 
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SparkMapJoinResolver.java.rej
patching file 
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
12 out of 12 hunks ignored -- saving rejects to file 
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java.rej
patching file 
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/index/IndexWhereProcessor.java
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
2 out of 2 hunks ignored -- saving rejects to file 
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/index/IndexWhereProcessor.java.rej
patching file 
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/index/IndexWhereTaskDispatcher.java
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
3 out of 3 hunks ignored -- saving rejects to file 
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/index/IndexWhereTaskDispatcher.java.rej
patching file 
ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/CombineEquivalentWorkResolver.java
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
2 out of 2 hunks ignored -- saving rejects to file 
ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/CombineEquivalentWorkResolver.java.rej
patching file 
ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SetSparkReducerParallelism.java
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
2 out of 2 hunks ignored -- saving rejects to file 
ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SetSparkReducerParallelism.java.rej
patching file 
ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkJoinHintOptimizer.java
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
2 out of 2 hunks ignored -- saving rejects to file 
ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkJoinHintOptimizer.java.rej
patching file 
ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkJoinOptimizer.java
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
2 out of 2 hunks ignored -- saving rejects to file 
ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkJoinOptimizer.java.rej
patching file 
ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkMapJoinOptimizer.java
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
2 out of 2 hunks ignored -- saving rejects to file 
ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkMapJoinOptimizer.java.rej
patching file 
ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkReduceSinkMapJoinProc.java
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
6 out of 6 hunks ignored -- saving rejects to file 
ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkReduceSinkMapJoinProc.java.rej
patching file 
ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkSMBJoinHintOptimizer.java
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
2 out of 2 hunks ignored -- saving rejects to file 
ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkSMBJoinHintOptimizer.java.rej
patching file 
ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkSkewJoinProcFactory.java
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
2 out of 2 hunks ignored -- saving rejects to file 
ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkSkewJoinProcFactory.java.rej
patching file 
ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkSkewJoinResolver.java
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
2 out of 2 hunks ignored -- saving rejects to file 
ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkSkewJoinResolver.java.rej
patching file 
ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkSortMergeJoinOptimizer.java
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
6 out of 6 hunks ignored -- saving rejects to file 
ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkSortMergeJoinOptimizer.java.rej
patching file 
ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
9 out of 9 hunks ignored -- saving rejects to file 
ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java.rej
patching file 
ql/src/java/org/apache/hadoop/hive/ql/optimizer/unionproc/UnionProcFactory.java
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
13 out of 13 hunks ignored -- saving rejects to file 
ql/src/java/org/apache/hadoop/hive/ql/optimizer/unionproc/UnionProcFactory.java.rej
patching file 
ql/src/java/org/apache/hadoop/hive/ql/parse/AppMasterEventProcessor.java
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
2 out of 2 hunks ignored -- saving rejects to file 
ql/src/java/org/apache/hadoop/hive/ql/parse/AppMasterEventProcessor.java.rej
patching file ql/src/java/org/apache/hadoop/hive/ql/parse/FileSinkProcessor.java
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
2 out of 2 hunks ignored -- saving rejects to file 
ql/src/java/org/apache/hadoop/hive/ql/parse/FileSinkProcessor.java.rej
patching file ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezUtils.java
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file 
ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezUtils.java.rej
patching file ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezWork.java
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
3 out of 3 hunks ignored -- saving rejects to file 
ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezWork.java.rej
patching file 
ql/src/java/org/apache/hadoop/hive/ql/parse/MacroSemanticAnalyzer.java
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
2 out of 2 hunks ignored -- saving rejects to file 
ql/src/java/org/apache/hadoop/hive/ql/parse/MacroSemanticAnalyzer.java.rej
patching file 
ql/src/java/org/apache/hadoop/hive/ql/parse/PrintOpTreeProcessor.java
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
2 out of 2 hunks ignored -- saving rejects to file 
ql/src/java/org/apache/hadoop/hive/ql/parse/PrintOpTreeProcessor.java.rej
patching file 
ql/src/java/org/apache/hadoop/hive/ql/parse/ProcessAnalyzeTable.java
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
2 out of 2 hunks ignored -- saving rejects to file 
ql/src/java/org/apache/hadoop/hive/ql/parse/ProcessAnalyzeTable.java.rej
patching file ql/src/java/org/apache/hadoop/hive/ql/parse/QBSubQuery.java
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
3 out of 3 hunks ignored -- saving rejects to file 
ql/src/java/org/apache/hadoop/hive/ql/parse/QBSubQuery.java.rej
patching file ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file 
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java.rej
patching file 
ql/src/java/org/apache/hadoop/hive/ql/parse/TableAccessAnalyzer.java
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
4 out of 4 hunks ignored -- saving rejects to file 
ql/src/java/org/apache/hadoop/hive/ql/parse/TableAccessAnalyzer.java.rej
patching file ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
6 out of 6 hunks ignored -- saving rejects to file 
ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java.rej
patching file 
ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
13 out of 13 hunks ignored -- saving rejects to file 
ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java.rej
patching file ql/src/java/org/apache/hadoop/hive/ql/parse/UnionProcessor.java
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
2 out of 2 hunks ignored -- saving rejects to file 
ql/src/java/org/apache/hadoop/hive/ql/parse/UnionProcessor.java.rej
patching file 
ql/src/java/org/apache/hadoop/hive/ql/parse/spark/GenSparkWork.java
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
2 out of 2 hunks ignored -- saving rejects to file 
ql/src/java/org/apache/hadoop/hive/ql/parse/spark/GenSparkWork.java.rej
patching file 
ql/src/java/org/apache/hadoop/hive/ql/parse/spark/SparkCompiler.java
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
5 out of 5 hunks ignored -- saving rejects to file 
ql/src/java/org/apache/hadoop/hive/ql/parse/spark/SparkCompiler.java.rej
patching file 
ql/src/java/org/apache/hadoop/hive/ql/parse/spark/SparkFileSinkProcessor.java
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
2 out of 2 hunks ignored -- saving rejects to file 
ql/src/java/org/apache/hadoop/hive/ql/parse/spark/SparkFileSinkProcessor.java.rej
patching file 
ql/src/java/org/apache/hadoop/hive/ql/parse/spark/SparkProcessAnalyzeTable.java
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
2 out of 2 hunks ignored -- saving rejects to file 
ql/src/java/org/apache/hadoop/hive/ql/parse/spark/SparkProcessAnalyzeTable.java.rej
patching file 
ql/src/java/org/apache/hadoop/hive/ql/parse/spark/SplitOpTreeForDPP.java
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
2 out of 2 hunks ignored -- saving rejects to file 
ql/src/java/org/apache/hadoop/hive/ql/parse/spark/SplitOpTreeForDPP.java.rej
patching file 
ql/src/java/org/apache/hadoop/hive/ql/ppd/ExprWalkerProcFactory.java
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
5 out of 5 hunks ignored -- saving rejects to file 
ql/src/java/org/apache/hadoop/hive/ql/ppd/ExprWalkerProcFactory.java.rej
patching file ql/src/java/org/apache/hadoop/hive/ql/ppd/OpProcFactory.java
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
11 out of 11 hunks ignored -- saving rejects to file 
ql/src/java/org/apache/hadoop/hive/ql/ppd/OpProcFactory.java.rej
patching file 
ql/src/java/org/apache/hadoop/hive/ql/ppd/PredicateTransitivePropagate.java
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
3 out of 3 hunks ignored -- saving rejects to file 
ql/src/java/org/apache/hadoop/hive/ql/ppd/PredicateTransitivePropagate.java.rej
patching file 
ql/src/java/org/apache/hadoop/hive/ql/ppd/SyntheticJoinPredicate.java
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
3 out of 3 hunks ignored -- saving rejects to file 
ql/src/java/org/apache/hadoop/hive/ql/ppd/SyntheticJoinPredicate.java.rej
patching file ql/src/java/org/apache/hadoop/hive/ql/tools/LineageInfo.java
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
2 out of 2 hunks ignored -- saving rejects to file 
ql/src/java/org/apache/hadoop/hive/ql/tools/LineageInfo.java.rej
patching file ql/src/test/org/apache/hadoop/hive/ql/lib/TestRuleRegExp.java
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
5 out of 5 hunks ignored -- saving rejects to file 
ql/src/test/org/apache/hadoop/hive/ql/lib/TestRuleRegExp.java.rej
+ exit 1
'
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12853867 - PreCommit-HIVE-Build

> stop using java.util.Stack
> --------------------------
>
>                 Key: HIVE-1626
>                 URL: https://issues.apache.org/jira/browse/HIVE-1626
>             Project: Hive
>          Issue Type: Improvement
>          Components: Query Processor
>    Affects Versions: 0.7.0
>            Reporter: John Sichi
>            Assignee: Teddy Choi
>         Attachments: HIVE-1626.2.patch
>
>
> We currently use Stack as part of the generic node walking library.  Stack 
> should not be used for this since its inheritance from Vector incurs 
> superfluous synchronization overhead.
> Most projects end up adding an ArrayStack implementation and using that 
> instead.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to