[
https://issues.apache.org/jira/browse/HIVE-15766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15884421#comment-15884421
]
Mohit Sabharwal commented on HIVE-15766:
----------------------------------------
LGTM, +1
A small nit that process() assumes that HMSHandler.getRawStore() threadlocal is
initialized. That threadlocal gets
initialized inside HMSHandler.getMS() which, in practice always gets called
before process() (
because we persist metadata before notification) -- so it will work in
practice. Maybe good to put a null check
to be safe.
> DBNotificationlistener leaks JDOPersistenceManager
> --------------------------------------------------
>
> Key: HIVE-15766
> URL: https://issues.apache.org/jira/browse/HIVE-15766
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Reporter: Vaibhav Gumashta
> Assignee: Vaibhav Gumashta
> Attachments: HIVE-15766.1.patch, HIVE-15766.2.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
