[
https://issues.apache.org/jira/browse/HIVE-16104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15900571#comment-15900571
]
Sergey Shelukhin edited comment on HIVE-16104 at 3/8/17 2:03 AM:
-----------------------------------------------------------------
Some things that look like refactoring are not actually refactoring. The lock
in trySchedule is unnecessary so I removed it and renamed the method;
preemption was surrounded by a loop because previously, if the first task in
queue was finishable it would bail without preempting anything even if there
are more tasks.
I can merge updateQueueMetric back into being copy-pasted in 3 places... also
one if was refactored because it has lots of repetitive code.
Another method was added because something that was previously called in one
place is now called in 2 places and I didn't want to copy-paste it.
was (Author: sershe):
Some things that look like refactoring are not actually refactoring. The lock
in trySchedule is unnecessary so I removed it and renamed the method;
preemption was surrounded by a loop because previously, if the first task in
queue was finishable it would bail without preempting anything even if there
are more tasks.
I can merge updateQueueMetric back into being copy-pasted in 3 places... also
one if was refactored because it has lots of repetitive code.
> LLAP: preemption may be too aggressive if the pre-empted task doesn't die
> immediately
> -------------------------------------------------------------------------------------
>
> Key: HIVE-16104
> URL: https://issues.apache.org/jira/browse/HIVE-16104
> Project: Hive
> Issue Type: Bug
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Attachments: HIVE-16104.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
