[ 
https://issues.apache.org/jira/browse/HIVE-16189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15922770#comment-15922770
 ] 

Chaoyu Tang commented on HIVE-16189:
------------------------------------

I thought about that, but it seems a little difficult to create such a test 
case where the HFDS rename (data move) fails in
{code}
       if (srcFs.exists(srcPath) && !srcFs.rename(srcPath, destPath)) {
            throw new IOException("Renaming " + srcPath + " to " + destPath + " 
failed");
       }
{code}
after the metadata change has been successfully committed. 
Do you have any suggestion on that? I was able to manually reproduce this issue 
and verify the patch by using debug breakpoint and simulating the file move 
failure.        

> Table column stats might be invalidated in a failed table rename
> ----------------------------------------------------------------
>
>                 Key: HIVE-16189
>                 URL: https://issues.apache.org/jira/browse/HIVE-16189
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Chaoyu Tang
>            Assignee: Chaoyu Tang
>         Attachments: HIVE-16189.patch
>
>
> If the table rename does not succeed due to its failure in moving the data to 
> the new renamed table folder, the changes in TAB_COL_STATS are not rolled 
> back which leads to invalid column stats.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to